maint: Harden ScopedContextChange#4337
Merged
jjerphan merged 2 commits intoJun 25, 2026
Merged
Conversation
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Klaim <Klaim@users.noreply.github.com>
jjerphan
changed the title
ScopedContextChange
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4337 +/- ##
==========================================
- Coverage 55.08% 55.07% -0.02%
==========================================
Files 240 240
Lines 30280 30302 +22
Branches 3235 3237 +2
==========================================
+ Hits 16681 16688 +7
- Misses 13596 13611 +15
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Klaim
approved these changes
Jun 24, 2026
Klaim
left a comment
Klaim
left a comment
Member
There was a problem hiding this comment.
LGTM 👍🏽 logging the failures would be cool but not sure how that would work in the context of Catch3
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Klaim <Klaim@users.noreply.github.com>
Klaim
approved these changes
Jun 25, 2026
JohanMabille
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #4334.
See #4334 (review).
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.